Get rid of warnings in compositor tests #2684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnuu
added
component:compositors
backwards-incompatibility
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2684 +/- ##
=======================================
Coverage 95.32% 95.32%
=======================================
Files 371 371
Lines 52435 52427 -8
=======================================
- Hits 49982 49975 -7
+ Misses 2453 2452 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 7182050794
💛 - Coveralls |
djhoese
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans the compositor tests so that they emit zero warnings when ran with
pytest -Werror satpy/tests/test_composites.py satpy/tests/compositor_tests/.The backwards incompatile change is the removal of
GreenCorrectorclass, which is not used internally, and was deprecated in November 2022 in v0.39.0. Someone might be using it in their own configs.The lower version limit of XArray is raised to v0.14.1 where
xr.DataArray.drop_vars()was added and.drop()was deprecated.Three deprecated AHI composites were removed, which were related to the deprecation of
GreenCorrector.